Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate domain types #918

Closed
2 tasks done
thanethomson opened this issue Jun 23, 2021 · 0 comments · Fixed by #922
Closed
2 tasks done

Deduplicate domain types #918

thanethomson opened this issue Jun 23, 2021 · 0 comments · Fixed by #922
Assignees
@thanethomson
Labels
domain-types Anything relating to the creation, modification or removal of domain types enhancement New feature or request

Comments

@thanethomson
Copy link
Member

thanethomson commented Jun 23, 2021 •
edited
Loading

There are some data structures (all domain types) that are duplicated between the tendermint and tendermint-rpc crates:

We need to remove one of each of these and refactor accordingly. We should also be on the lookout for any other duplicate data structures and prune them ASAP (and add them to this issue).

What's the definition of "done" for this issue?

When there's only one of each domain type.
@thanethomson thanethomson added enhancement New feature or request domain-types Anything relating to the creation, modification or removal of domain types labels Jun 23, 2021
@thanethomson thanethomson self-assigned this Jun 24, 2021
@thanethomson thanethomson mentioned this issue Jun 25, 2021
Merged
5 tasks
@romac romac mentioned this issue Jul 13, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanethomson thanethomson

Labels
domain-types Anything relating to the creation, modification or removal of domain types enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deduplicate RPC domain types informalsystems/tendermint-rs
1 participant
@thanethomson