Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PartialEq, Eq, PartialOrd, Ord, Hash bounds to tendermint_rpc::Url #919

Closed
romac opened this issue Jun 24, 2021 · 0 comments · Fixed by #921
Closed

Add PartialEq, Eq, PartialOrd, Ord, Hash bounds to tendermint_rpc::Url #919

romac opened this issue Jun 24, 2021 · 0 comments · Fixed by #921
Labels
enhancement New feature or request

Comments

@romac
Copy link
Member

romac commented Jun 24, 2021

On order to implement runtime configuration reload in Hermes, we need to be able to compare two configurations for equality.
We are currently not able to do that, because our configuration struct contains a few fields of type tendermint_rpc::Url, which does not implement the Eq trait.

It would be great if we could derive this trait for tendermint_rpc::Url, and add other standard trait bounds while we're at it. The full list I am thinking of is: PartialEq, Eq, PartialOrd, Ord, Hash.

What's the definition of "done" for this issue?

tendermint_rpc::Url implements PartialEq, Eq, PartialOrd, Ord, Hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant