Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on Tendermint Core #168

Merged
merged 14 commits into from Jan 19, 2023
Merged

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Jan 18, 2023

This PR entirely removes tm-load-test's dependency on the Tendermint Core Go package. This is temporary while Informal Systems readies its fork of Tendermint Core.

As such, some rudimentary functionality and types had to be replicated in the loadtest package. This will most likely be removed in future.

Instead of manually constructing a Tendermint node in an integration test, this now sets up a 4-node localnet and executes a standalone and coordinated load test against this 4-node network, while still preserving the coverage.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson added the T:dependencies Dependency updates label Jan 18, 2023
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #168 (b4d90b9) into main (a9c21a5) will increase coverage by 8.13%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   52.70%   60.84%   +8.13%     
==========================================
  Files          16       18       +2     
  Lines        1958     2056      +98     
==========================================
+ Hits         1032     1251     +219     
+ Misses        825      678     -147     
- Partials      101      127      +26     
Impacted Files Coverage Δ
pkg/loadtest/rpc.go 46.15% <46.15%> (ø)
pkg/loadtest/rand.go 50.00% <50.00%> (ø)
pkg/loadtest/client_kvstore.go 66.66% <100.00%> (ø)
pkg/loadtest/coordinator.go 72.47% <100.00%> (+2.52%) ⬆️
pkg/loadtest/loadtest.go 59.57% <100.00%> (+23.40%) ⬆️
pkg/loadtest/tm_network_info.go 77.22% <100.00%> (+77.22%) ⬆️
pkg/loadtest/transactor.go 61.75% <100.00%> (ø)
pkg/loadtest/worker.go 58.82% <0.00%> (+4.97%) ⬆️
... and 1 more

… Docker

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
test/docker-compose.yml Outdated Show resolved Hide resolved
test/integration-test.sh Outdated Show resolved Hide resolved
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson merged commit 4edcd62 into main Jan 19, 2023
@thanethomson thanethomson deleted the thane/rm-tendermint-dep branch January 19, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants