Expand on endpoint selection strategy #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows for a broader endpoint selection strategy for load testing. Specifically, there are 3 possible strategies for selecting endpoints for load testing: 1. "supplied" - use only supplied endpoints for load testing. 2. "discovered" - use only discovered endpoints for load testing (and none of the supplied ones). 3. "any" - use both supplied and discovered endpoints for testing. This allows for permutations such as when one supplies a seed node as an endpoint, but one does not want to submit transactions to that seed node. This necessarily introduces another command line parameter `--max-endpoints`, which allows one to restrict the maximum number of endpoints returned for load testing after applying the selection strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows for a broader endpoint selection strategy for load testing. Specifically, there are 3 possible strategies for selecting endpoints for load testing:
This allows for permutations such as when one supplies a seed node as an endpoint, but one does not want to submit transactions to that seed node.
This necessarily introduces another command line parameter
--max-endpoints, which allows one to restrict the maximum number of endpoints returned for load testing after applying the selectionstrategy.