Add Gitlab support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaligar
force-pushed
the
add_gitlab
branch
3 times, most recently
from
1f49f29
to
d62241c
Compare
|
Fixed the failed test and the formatting. |
thaligar
force-pushed
the
add_gitlab
branch
3 times, most recently
from
edfb2c5
to
beca091
Compare
|
Fixed the clippy issues. |
|
Hey @thaligar! Sorry for the delay in getting feedback to you here, I've been swamped with other work over the past couple of weeks. Thanks for your thoughtful contribution here! I've fixed the latest clippy warnings/errors for Rust v1.67 in #42 - please rebase your PR here and I'll review this soon! |
|
Hi @thanethomson, no problem I thought so. |
thanethomson
requested changes
Feb 14, 2023
There was a problem hiding this comment.
I have a few recommendations, but overall it's great, and much appreciated @thaligar!
|
Hi @thanethomson, fixed all issues. I added a comment at the "UnrecognizedProjectType". Fmt, clippy and tests were run before pushing. |
thanethomson
approved these changes
Mar 10, 2023
|
@thanethomson No problem. Thanks for the great tool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added GitLab support. I tested it with online and diy-GitLab instance.
I realized the polymorphism via enums.
Please give me a buzz if there is anything not according to your standards or if you prefer 'dyn traits' over enums.
I am happy to change to your needs.