Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OP-1220 Add Supplier comparator to sort in combobox #1330

Merged
merged 3 commits into from
May 10, 2024
Merged

OP-1220 Add Supplier comparator to sort in combobox #1330

merged 3 commits into from
May 10, 2024

Conversation

mwithi
Copy link
Member

@mwithi mwithi commented May 9, 2024

See OP-1220.

@mwithi mwithi requested a review from dbmalkovsky May 9, 2024 20:46
dbmalkovsky
dbmalkovsky approved these changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mwithi mwithi merged commit 4502f7d into release_1_14_2 May 10, 2024
2 checks passed
@mwithi mwithi deleted the OP-1220-add-supplier-comparator-to-sort-in-combobox branch May 10, 2024 15:47
mwithi added a commit that referenced this pull request May 10, 2024
@mwithi
OP-1220 Add Supplier comparator to sort in combobox (#1330)
9ceab04 
* OP-1220 Add Supplier comparator to sort in combobox

* Replace compareTo with Apache Commons compare

* Organize imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbmalkovsky dbmalkovsky dbmalkovsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwithi @dbmalkovsky