Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbook_new_opt not implemented for libxlsxwriter #22

Closed
kindly opened this issue Jul 7, 2021 · 1 comment
Closed

workbook_new_opt not implemented for libxlsxwriter #22

kindly opened this issue Jul 7, 2021 · 1 comment

Comments

@kindly
Copy link
Contributor

kindly commented Jul 7, 2021

For large xslx files is it useful to put constant memory mode on in libxlsxwriter.

To do this you need to call workbook_new_opt instead of workbook_new also passing in the configuration struct.
https://libxlsxwriter.github.io/workbook_8h.html#a8ca9bd8c30c618b81ca6180f78b03323

I imagine in
https://github.com/informationsea/xlsxwriter-rs/blob/master/libxlsxwriter/src/workbook.rs#L28
a new static method new_with_opt would make sense as it mirrors C api. I imagine bindgen has generated the code in libxlsxwriter_sys making bindings for this function and struct, so "in theory" this looks fairly strait foward.

Nonetheless I have no experiance of any C bindings before but will have a go if the approach is considered right. Also would be very happy for someone else to do it if it quick and easy for them.

@kindly kindly changed the title workbook_new_opt not implemented for libxmlwriter workbook_new_opt not implemented for libxlsxwriter Jul 7, 2021
@informationsea
Copy link
Owner

I merged your pull request. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants