Fixes for A lookups, optional number-suffix, time left #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
avlidienbrunn
commented
Jun 22, 2016
avlidienbrunn
commented
- Fix for bug that resulted in no A lookups (check "result is None" vs check "len(result)")
- Fix for bug that made number-suffix only be 0-8 (as opposed to 0-9)
- Added approximate time left
- Made number-suffix optional with -n
range should go to 9 instead of 8
Kinda fulhack, but it works.
Changed from checking if result array is None to checking the length of the array. Now DNS A lookups should work.
Optional flag for adding number suffix
…file when alternating starts
Also fixed bug with A vs CNAME
A/CNAME both works now + Cleaning of output before alternation
…nged so remove existing works the same way
Must wait for threads so the script doesn't stop until they are done.
changed from subprocess sort to python set() for uniqueness.
Properly wipe the correct file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.