Skip to content

Commit

Permalink
Fixing WindowsStore 10 apps to have a 44x44 small logo asset.
Browse files Browse the repository at this point in the history
With the release of the 1.1 Tools. The small logo size is enforced at 44x44
  • Loading branch information
Gilles Khouzam committed Sep 25, 2015
1 parent 77d9d3c commit 280597b
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 2 deletions.
11 changes: 10 additions & 1 deletion Source/cmVisualStudio10TargetGenerator.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -3457,7 +3457,8 @@ void cmVisualStudio10TargetGenerator::WriteMissingFilesWS10_0()
"\t\t\t\tDescription=\"" << targetNameXML << "\"\n"
"\t\t\t\tBackgroundColor=\"#336699\"\n"
"\t\t\t\tSquare150x150Logo=\"" << artifactDirXML << "\\Logo.png\"\n"
"\t\t\t\tSquare44x44Logo=\"" << artifactDirXML << "\\SmallLogo.png\">\n"
"\t\t\t\tSquare44x44Logo=\"" << artifactDirXML <<
"\\SmallLogo44x44.png\">\n"
"\t\t\t\t<uap:SplashScreen"
" Image=\"" << artifactDirXML << "\\SplashScreen.png\" />\n"
"\t\t\t</uap:VisualElements>\n"
Expand Down Expand Up @@ -3491,6 +3492,14 @@ ::WriteCommonMissingFiles(const std::string& manifestFile)
(*this->BuildFileStream) << cmVS10EscapeXML(smallLogo) << "\" />\n";
this->AddedFiles.push_back(smallLogo);

std::string smallLogo44 = this->DefaultArtifactDir + "/SmallLogo44x44.png";
cmSystemTools::CopyAFile(templateFolder + "/SmallLogo44x44.png",
smallLogo44, false);
this->ConvertToWindowsSlash(smallLogo44);
this->WriteString("<Image Include=\"", 2);
(*this->BuildFileStream) << cmVS10EscapeXML(smallLogo44) << "\" />\n";
this->AddedFiles.push_back(smallLogo44);

std::string logo = this->DefaultArtifactDir + "/Logo.png";
cmSystemTools::CopyAFile(templateFolder + "/Logo.png",
logo, false);
Expand Down
Binary file added Templates/Windows/SmallLogo44x44.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions Tests/VSWinStorePhone/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ elseif (NOT "${PLATFORM}" STREQUAL "DESKTOP")
set(ASSET_FILES ${ASSET_FILES}
Direct3DApp1/Assets/Logo.png
Direct3DApp1/Assets/SmallLogo.png
Direct3DApp1/Assets/SmallLogo44x44.png
Direct3DApp1/Assets/SplashScreen.png
Direct3DApp1/Assets/StoreLogo.png
)
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
Description="@SHORT_NAME@"
BackgroundColor="#336699"
Square150x150Logo="Assets/Logo.png"
Square44x44Logo="Assets/SmallLogo.png">
Square44x44Logo="Assets/SmallLogo44x44.png">
<uap:SplashScreen Image="Assets/SplashScreen.png" />
</uap:VisualElements>
</Application>
Expand Down

0 comments on commit 280597b

Please sign in to comment.