Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sensitivity.R from utils to uncertainty #6

Closed
wants to merge 38 commits into from

Conversation

moki1202
Copy link

please refer #2856 for any information.

@moki1202
Copy link
Author

/document

@infotroph
Copy link
Owner

@moki1202 This will eventually want to be merged into the main PecanProject repo rather than my fork, which will need a new PR but no change in commits. But I think it makes sense to keep this PR open for now and redirect it to the main repo after PecanProject#2854 is merged -- that way GitHub will only show the changes you've made on top of my previous commits, making it easier to keep track of what you're doing.

@infotroph
Copy link
Owner

/document

@infotroph
Copy link
Owner

@moki1202 looks like /document doesn't work outside the main repo :(
Do you have your VM set up such that you can run Roxygen (version 7.0.2, please) there and push the results? If not, ping me and we'll get it set up.

@moki1202
Copy link
Author

@infotroph yep VM is up and working,

@infotroph
Copy link
Owner

@moki1202 great! From the initial CI results and also from what we know about R packages, the files to be updated will be:

modified: base/utils/NAMESPACE, modules/uncertainty/NAMESPACE
deleted: base/utils/man/read.sa.output.Rd, base/utils/man/write.sa.configs.Rd
added: modules/uncertainty/man/read.sa.output.Rd, modules/uncertainty/man/write.sa.configs.Rd

That should let the checks get far enough to find out whether there are further adjustments needed (e.g. dependencies that can be removed from utils / need to be added to uncertainty; references to utils functions that need to have namespaces added now that they're being called from another package).

Utils: Quiet Roxygen complaints + style tweaks + remove now-unused dependencies
…process

Using ed2_pft_number tag in ED2 E files postprocessing
@infotroph
Copy link
Owner

@moki1202 My utils branch is now merged into develop, so you can now open this as a PR into the main repo.

@infotroph
Copy link
Owner

PR was moved to PecanProject#2857; closing here

@infotroph infotroph closed this Sep 23, 2021
mdietze pushed a commit that referenced this pull request Mar 6, 2022
Move remote.copy.update into data.land (as an internal helper)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants