Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): merge lib and app translations and fix search-selector tr… #498

Merged
merged 1 commit into from
Oct 31, 2019

Conversation

cbourget
Copy link
Collaborator

…anslation key

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
There is no way for an app using the lib to define translations under the igo namespace.

What is the new behavior?
Use the merge deep strategy to combine translations from an app and igo.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@mbarbeau mbarbeau merged commit 175e637 into master Oct 31, 2019
@mbarbeau mbarbeau deleted the merge-translations branch October 31, 2019 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants