feat(export): added possibility of exporting merged CSV files #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| filename = data.name; | ||
| } | ||
| } else { | ||
| filename = "combinedLayers"; |
There was a problem hiding this comment.
Translation would be better
| } | ||
| }); | ||
| }; | ||
| if ((data.format === ExportFormat.CSVsemicolon || data.format === ExportFormat.CSVcomma) && data.combineLayers) { |
There was a problem hiding this comment.
Should be put into else condition (line 561) ?
| () => { | ||
| this.onFileExportSuccess(); | ||
|
|
||
| featuresCSV.forEach(feature => { |
There was a problem hiding this comment.
Create method instead ? Could be also use for geomType at line 609
…rte/igo2-lib into export_csv_unique
PhilippeLafreniere18
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
When exporting multiple layers, if the comma separated CSV or Excel compatible CSV option is selected, one CSV file is exported per layer.
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: