fix(ICherche): add a custom cache hash to account for http params #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alecarn
changed the title
alecarn
changed the title
|
@alecarn Does the custom cache buster must be implemented for other search sources (reverse TerrApi, iLayers...?) |
|
Yes we need to change our approach for these sources. If you accept this PR, I will create another ticket to apply this solution to the problem. |
…into IGO2-928_bust-the-cache-on-search
fix(OsrmDirection): route fix(Cadastre): search fix(iLayer): search fix(Nominatim): search fix(StoredQueries): search and reverseSearch
|
@pelord, I applied the same logic to other problematic cached query. It's ready for a second review and I will appreciate if you can test. |
pelord
requested changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
infra-geo-ouverte/igo2#928
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
infra-geo-ouverte/igo2#928
What is the new behavior?
A new property to configure the SearchBar and invalidate the cache after a settings change
bustCacheOnSettingChangeDoes this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: