feat(geo): Print with resolution PDF and image #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
enhancement
|
On ne peut pas faire la revue de cette PR car on a inclus #1256. En stand-by tant que cette PR n'est pas mergé ou corriger cette PR pour ne pas l'inclure. |
alecarn
requested changes
Jun 22, 2023
| @@ -830,15 +830,28 @@ export class PrintService { | |||
| legendPosition: PrintLegendPosition | |||
| ) { | |||
| const status$ = new Subject(); | |||
| // const resolution = map.ol.getView().getResolution(); | |||
There was a problem hiding this comment.
Dans les paramètres de la méthode, on pourrait ajouter le type pour la résolution: PrintResolution
| // Reset original map size | ||
| map.ol.setSize(initialMapSize); | ||
| map.ol.getView().setResolution(viewResolution); | ||
| map.ol.renderSync(); |
There was a problem hiding this comment.
On peut éviter le commentaire en refactorant cette partie et créer un méthode resetOriginalMapSize(size, resolution)
Comment on lines
1035
to
1038
| // Set map image size | ||
| map.ol.setSize(newMapSize); | ||
| const scaling = Math.min(newMapSize[0] / initialMapSize[0], newMapSize[1] / initialMapSize[1]); | ||
| map.ol.getView().setResolution(viewResolution / scaling); |
There was a problem hiding this comment.
Pour éviter de laisser des commentaire on pourrait en faire un méthode, cela améliorait aussi la lisibilité.
Suggested change
| // Set map image size | |
| map.ol.setSize(newMapSize); | |
| const scaling = Math.min(newMapSize[0] / initialMapSize[0], newMapSize[1] / initialMapSize[1]); | |
| map.ol.getView().setResolution(viewResolution / scaling); | |
| setMapResolution(initialSize: [number, number], resolution: PrintResolution): void { | |
| const scaleFactor = resolution / 96; | |
| const [width, height] = initialSize; | |
| const scaledSize = [Math.round(width * scaleFactor), Math.round(height * scaleFactor)]; | |
| map.ol.setSize(scaledSize); | |
| const scaling = Math.min(scaledSize[0] / width, scaledSize[1] / height); | |
| const view = map.ol.getView(); | |
| view.setResolution(view.getResolution() / scaling); | |
| } |
…setMapResolution for pdf
alecarn
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this behavior related to #402 in igo2
What is the new behavior?
Ability to choose the resolution before exporting pdf or image
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: