Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(draw): drawing circle crash whole drawing component. #1273

Merged
merged 1 commit into from
May 31, 2023
Merged

fix(draw): drawing circle crash whole drawing component. #1273

merged 1 commit into from
May 31, 2023

Conversation

pelord
Copy link
Member

@pelord pelord commented May 31, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
Drawing circle cause crash
image

What is the new behavior?
Fix it.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord merged commit 3998dcc into next May 31, 2023
5 checks passed
@pelord pelord deleted the df branch May 31, 2023 18:02
alecarn pushed a commit that referenced this pull request Jun 12, 2023
alecarn added a commit that referenced this pull request Jun 12, 2023
* Insert accent hashtag (#1258)

* premier_test_ajout_hastags

* insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-)

---------

Co-authored-by: karengeo <karenchoquehuancaquispe@gmail.com>
(cherry picked from commit cf74db7)

* Corriger le parseInt qui ajuste normalement les attributs en integer (#1257)

* Corriger le parseInt qui ajuste normalement les attributs en integer

* Make condition a function

(cherry picked from commit 1d807d6)

* fix(draw): drawing circle crash whole drawing component. (#1273)

(cherry picked from commit 3998dcc)

* chore(Package): run the build once

* 1.15.3

---------

Co-authored-by: MSPKarengeo <90481471+MSPKarengeo@users.noreply.github.com>
Co-authored-by: Michael Lane <michael.lane@msp.gouv.qc.ca>
Co-authored-by: Pierre-Étienne Lord <7397743+pelord@users.noreply.github.com>
@alecarn alecarn mentioned this pull request Jun 12, 2023
5 tasks
alecarn added a commit that referenced this pull request Jun 14, 2023
* Insert accent hashtag (#1258)

* premier_test_ajout_hastags

* insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-)

---------

Co-authored-by: karengeo <karenchoquehuancaquispe@gmail.com>
(cherry picked from commit cf74db7)

* Corriger le parseInt qui ajuste normalement les attributs en integer (#1257)

* Corriger le parseInt qui ajuste normalement les attributs en integer

* Make condition a function

(cherry picked from commit 1d807d6)

* fix(draw): drawing circle crash whole drawing component. (#1273)

(cherry picked from commit 3998dcc)

* chore(Package): run the build once

* 1.15.3

---------

Co-authored-by: MSPKarengeo <90481471+MSPKarengeo@users.noreply.github.com>
Co-authored-by: Michael Lane <michael.lane@msp.gouv.qc.ca>
Co-authored-by: Pierre-Étienne Lord <7397743+pelord@users.noreply.github.com>
pelord added a commit that referenced this pull request Jun 14, 2023
* Insert accent hashtag (#1258)

* premier_test_ajout_hastags

* insert_accent_to_the_keywords_in_order_to_use_hashtag_and(-)

---------

Co-authored-by: karengeo <karenchoquehuancaquispe@gmail.com>
(cherry picked from commit cf74db7)

* Corriger le parseInt qui ajuste normalement les attributs en integer (#1257)

* Corriger le parseInt qui ajuste normalement les attributs en integer

* Make condition a function

(cherry picked from commit 1d807d6)

* fix(draw): drawing circle crash whole drawing component. (#1273)

(cherry picked from commit 3998dcc)

* chore(Package): run the build once

* 1.15.3

* refactor(workspaces): move common method to workspace utils

* feat(workspaces): sourcefields with types add a cellClassFunc to the table template

* refactor(entity-table): typo

* fix(workspace): table scroll/overflow was not accessible

* lint

* lint

* wip

---------

Co-authored-by: MSPKarengeo <90481471+MSPKarengeo@users.noreply.github.com>
Co-authored-by: Michael Lane <michael.lane@msp.gouv.qc.ca>
Co-authored-by: Alexandre Caron <alexandre.caron12@msp.gouv.qc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant