Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EntityTable): validate octal number #1293

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix(EntityTable): validate octal number #1293

merged 2 commits into from
Sep 11, 2023

Conversation

alecarn
Copy link
Collaborator

@alecarn alecarn commented Jun 14, 2023

No description provided.

@alecarn alecarn requested a review from pelord June 14, 2023 23:27
pelord
pelord requested changes Jun 15, 2023
View reviewed changes
Copy link
Member

@pelord pelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change for something like : return isNaN(Number(value)) ? false : true;

@alecarn alecarn self-assigned this Jun 16, 2023
@alecarn alecarn requested a review from pelord September 8, 2023 13:00
@pelord pelord merged commit 860ea7e into next Sep 11, 2023
5 checks passed
@pelord pelord deleted the fix-entity-table-decimal-number branch September 11, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelord pelord pelord approved these changes

Assignees

@alecarn alecarn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alecarn @pelord