-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style refactoring #1305
Merged
Merged
Style refactoring #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove gulp script - Remove scss-bundle - Remove magic import
|
- I got a coming PR who will allow to test the demo with upcoming change from the lib
…into refact-styles
alecarn
commented
Jul 10, 2023
alecarn
commented
Jul 13, 2023
…ctor." This reverts commit fb15903.
pelord
approved these changes
Jul 18, 2023
We fix it with the script postbuild-core.ts
pelord
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one, we refactored all the library style.
TO TEST THIS PR, YOU NEED TO:
What is the current behavior? (You can also link to an open issue here)
All the prebuilt themes was bundled and loaded in each app
What is the new behavior?
Compile prebuilt themes seperately and load only the theme we need.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
The theming configuration has change. We need to check each application, who are not using prebuilt-themes. If your application configure manually the theme, please see the file demo/src/style.scss in the Demo and then the theme config
Other information: