1281-circular-dependencies-code-design #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncies-code-design
pelord
requested changes
Sep 8, 2023
packages/geo/src/lib/datasource/shared/datasources/wms-datasource.interface.ts
Show resolved
Hide resolved
packages/geo/src/lib/map/shared/controllers/geolocation.interface.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/workspace/shared/edition-workspace.service.ts
Outdated
Show resolved
Hide resolved
…ncies-code-design
- Map: rename abstate MapBase to avoid confusion - WfsWorkspace: add null check - EditionWorkspace: rework the params presentation
pelord
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix circular dependencies and add verification into the pipeline. We were aware of these circular dependencies but it was not critical until now. This work was necessary to validate certain assumptions to create symbolic links between the projects and the library #1346