fix(geo,common): create new color picker component #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odal drawing with the new color component
aziz-access
added
bug
alecarn
requested changes
Sep 7, 2023
packages/common/src/lib/color-picker/x-color-picker.component.html
Outdated
Show resolved
Hide resolved
packages/common/src/lib/color-picker/x-color-picker.component.ts
Outdated
Show resolved
Hide resolved
packages/common/src/lib/color-picker/x-color-picker.component.ts
Outdated
Show resolved
Hide resolved
packages/common/src/lib/color-picker/x-color-picker.component.ts
Outdated
Show resolved
Hide resolved
packages/common/src/lib/color-picker/x-color-picker.component.ts
Outdated
Show resolved
Hide resolved
packages/common/src/lib/color-picker/x-color-picker.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/style/style-modal/drawing/style-modal-drawing.component.html
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/style/style-modal/drawing/style-modal-drawing.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/style/style-modal/layer/style-modal-layer.component.html
Outdated
Show resolved
Hide resolved
…into 1330-color-picker-position
alecarn
requested changes
Sep 13, 2023
packages/common/src/lib/color-picker-form-field/color-picker-form-field.component.ts
Show resolved
Hide resolved
…into 1330-color-picker-position
alecarn
approved these changes
Sep 13, 2023
alecarn
added
to test
|
@pelord ready for your review |
pelord
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
This behavior related to #1330
What is the new behavior?
Use native html component
<input type="color">Create new color picker component
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: