Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1346 symbolic link between our projects and the library #1373

Merged
merged 46 commits into from
Oct 31, 2023
Merged

1346 symbolic link between our projects and the library #1373

merged 46 commits into from
Oct 31, 2023

Conversation

alecarn
Copy link
Collaborator

@alecarn alecarn commented Sep 11, 2023

An update to the architecture to allow a better developer experience with way to debug our application with the library. This solution is a workaround since we were not able to create real symbolic link with the packages managers (npm, yarn).

To allow our custom symbolic link, we made several modification:

  1. Use the workspace architecture
  2. Use the workspace link between the packages, see the * for referencing the dependency of @igo2/*
  3. Convert package to internal, see the exports property in package.json of packages
  4. Rework the style output to allow similitude when we develop with symbolic link or not, see the src/style in ng-packagr
  5. Add a projects folder, where external project will be checkout
  6. Rework the build and deployment process

Unfortunately, each project will need some modification

  1. a path resolver for @igo2/* in is tsconfig to allow a fallback to the symbolic link
  2. Custom resolver for the assets, see angular.json

alecarn and others added 30 commits August 16, 2023 15:37
@alecarn
fix useDefineForClassFields
f2cf8dd
@alecarn
feat: add circular-dependencies detection
9d54bc1
@alecarn
fix(Geo): remove circular dependencies
42de6bf
@alecarn
fix(Common): resolve circular dependencies
138ded8
@alecarn
feat(Action): add circular deps. check
7e625a6
@alecarn
fix spatial-filter
f286d2d
@alecarn
Merge branch '1281-circular-dependencies-code-design' of https://gith…
9b7d476 
…ub.com/infra-geo-ouverte/igo2-lib into 1346-symbolic-link-between-our-projects-and-the-library
@alecarn
fix(Compile) add partial compilation mode
271ddb5
@alecarn
WIP
fc2f834
@alecarn
fix(Postbuild): transfer the importation styles file in watch mode
287b5ac
@alecarn
feat(Architecture): handle scripts in workspace
fc7f2da 
- feat(Scripts): handle lib packages cross dependencies
@alecarn
fix: build errors due to undefined properties
bbc2c35
@alecarn
fix(Exec): handle spawn command for linux
fa7cc17
@alecarn
fix version bumping and convert Gulp script to Typescript
ef8e758
@alecarn
fix(CI-Actions): remove gulp installation
11ffb7d
@alecarn
feat(Symlink): resolve public_api via package.json
a7e6ae7
@alecarn
Add launch
3233762
@alecarn
revert(Geolocation): accidently delete overlay
d12eb67
@alecarn
Merge branch 'migrate-tsconfig-use-define-for-class-fields' of https:…
7f4baa0 
…//github.com/infra-geo-ouverte/igo2-lib into 1346-symbolic-link-between-our-projects-and-the-library
@pelord
Merge remote-tracking branch 'origin/next' into 1281-circular-depende…
4b5d4f5 
…ncies-code-design
@alecarn
fix: build errors due to undefined properties
debc0a0
@alecarn
fix(Catalog): propagate the parent scope
5e8ccaa
@pelord
Merge remote-tracking branch 'origin/next' into 1281-circular-depende…
779eba4 
…ncies-code-design
@alecarn
fix: build errors due to undefined properties
707ca12
@alecarn
fix: code review many fix
0a6f70d 
- Map: rename abstate MapBase to avoid confusion
- WfsWorkspace: add null check
- EditionWorkspace: rework the params presentation
@alecarn
Merge branch '1281-circular-dependencies-code-design' of https://gith…
e00c170 
…ub.com/infra-geo-ouverte/igo2-lib into 1346-symbolic-link-between-our-projects-and-the-library
@alecarn
remove submodule
6f944ae
@alecarn
Merge branch 'next' of https://github.com/infra-geo-ouverte/igo2-lib …
70cd394 
…into 1346-symbolic-link-between-our-projects-and-the-library
@alecarn
remove submodule
7c05fc4
@alecarn
Add projects in gitignore
5da8fbf
@alecarn alecarn mentioned this pull request Sep 11, 2023
Merged
@alecarn alecarn requested a review from pelord September 11, 2023 18:06
@alecarn alecarn marked this pull request as ready for review September 11, 2023 18:06
@alecarn alecarn self-assigned this Sep 18, 2023
@alecarn alecarn linked an issue Sep 18, 2023 that may be closed by this pull request
Symbolic link between our projects and the library #1346
Closed
@pelord pelord changed the base branch from next to release/16.0.0 October 17, 2023 18:05
pelord
pelord reviewed Oct 18, 2023
View reviewed changes
.gitignore Show resolved Hide resolved
demo/tsconfig.app.json Outdated Show resolved Hide resolved
demo/tsconfig.spec.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/geo/tsconfig.lib.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
packages/auth/package.json Show resolved Hide resolved
packages/geo/tsconfig.lib.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
scripts/src/watch-library.ts Outdated Show resolved Hide resolved
alecarn and others added 2 commits October 23, 2023 15:28
@alecarn
Merge branch 'release/16.0.0' of https://github.com/infra-geo-ouverte…
26d37cf 
…/igo2-lib into 1346-symbolic-link-between-our-projects-and-the-library
@pelord
Merge remote-tracking branch 'origin/release/16.0.0' into 1346-symbol…
1ea9dad 
…ic-link-between-our-projects-and-the-library
@alecarn alecarn changed the base branch from release/16.0.0 to next October 27, 2023 18:00
@alecarn alecarn merged commit 1bea11c into next Oct 31, 2023
4 checks passed
@alecarn alecarn deleted the 1346-symbolic-link-between-our-projects-and-the-library branch October 31, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelord pelord pelord approved these changes

Assignees

@alecarn alecarn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symbolic link between our projects and the library
2 participants
@alecarn @pelord