Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import context with style (drawing layer) #1374

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

pelord
Copy link
Member

@pelord pelord commented Sep 12, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
this behavior related to #1337

What is the new behavior?
1- Store the feature style as an igoStyleObject within _style property.
2- Store the label inside the _mapTitle property.

Overall, this PR propose to use existing mecanism to handle styles during import (context or data). This is a "temporary" fix. I think we need to create a new layer type or extend the vector type, to handle internal layer types (draw, directions, measures) to be handled easily, on export/import.

Furthermore, the style handling will be changed shortly by using the geostyler library.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@aziz-access
Copy link
Contributor

For style exporting is done with draw layers. but with importing we have issue with circles and points radius.
the radius changes with zoom level.
I think this related to projection 'EPSG:4326'.
Example: Circles 100km - zoom: 6.
image
Example: Circle 100km - zoom: 5.
image

@pelord
Copy link
Member Author

pelord commented Sep 12, 2023

Does your PR (#1359) fix this issue?

@aziz-access
Copy link
Contributor

yes, we need your confirmation

@pelord pelord merged commit ca7f5ec into next Sep 13, 2023
4 checks passed
@pelord pelord deleted the fix-import-context-with-style branch September 13, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants