chore(*): refactor to set the configs files not dependent from any ht… #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Config file was dependent from Httpclient.
The fact is: Httpclient must instanciate Http_Interceptor .
But our AuthInterceptor was dependent from our config files....
What is the new behavior?
Disconnect the config files dependency to Httpclient.
Use the HttpBackend handler to make calls. Then the http_interceptors do not intercept theses calls.
angular/angular#26845
https://stackoverflow.com/questions/46469349/how-to-make-an-angular-module-to-ignore-http-interceptor-added-in-a-core-module/49013534#49013534
I think this is a final solution to solve #1004
@cbourget, We will probably merge soon. But just to get you informed.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Config files/Translations files and style-list service files are no more intercepted by AuthInterceptor due to the usage of HttpBackend handler
Other information: