-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui:(core, geo): fix input form width, change overly pane to fit-content #1395
Conversation
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le package-lock ne devrait pas se retrouver dans cette PR
packages/core/src/style/style.scss
Outdated
.cdk-overlay-pane:has(.mat-mdc-select-panel, .mat-mdc-autocomplete-panel) { | ||
/* styles to apply if the content contains select-panel OR autocomplete-panel */ | ||
min-width: fit-content; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pour l'appliquer de manière globale, est-ce que le mat-select de Angular est brisé?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
il est brisé lorsque la largeur de matSelect est plus longue qu'une option, la largeur du panneau ne s'étend pas jusqu'à la largeur de matSelect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça semble être un comportement voulu de Material, voir le dernier point. Pour ce "Hot Fix", est-ce qu'on pourrait l'appliquer localement seulement pour la composante problématique et on ré-analysera plus tard si on l'applique gloabalement.
…/igo2-lib into 1360-timefilter-style-regression
Comment que tu faisais pour le tester dans IGO2, quel contexte tu utilisais? |
.cdk-overlay-pane:has(.mat-mdc-select-panel, .mat-mdc-autocomplete-panel) { | ||
/* styles to apply if the content contains select-panel OR autocomplete-panel */ | ||
min-width: fit-content; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je crois que cela va tout de même appliquer le style globallement, tu pourrais le déplacer a l'intérieur du fichier ogc-filter-form-component.scss
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'ai essayé mais le style ne se charge pas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ogc-filterable-form.component
charger tout le ogc filtre, j'ai ajouter providers config pour résoudre l'issue:
MatSelect .cdk-overlay-pane
et MatAutocomplete .cdk-overlay-pane
:
providers: [
{
provide: MAT_SELECT_CONFIG,
useValue: { overlayPanelClass: 'igo-overlay-panel-width' }
},
{
provide: MAT_AUTOCOMPLETE_DEFAULT_OPTIONS,
useValue: { overlayPanelClass: 'igo-overlay-panel-width' }
}
]
@pelord prêt pour la revue |
What is the current behavior? (You can also link to an open issue here)
this behavior related to #1360
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: