feat(direction): add a toogle to control user interaction with map #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
requested changes
Sep 20, 2023
Comment on lines
449
to
457
| if (toggle) { | ||
| this.interactions.map((interaction) => | ||
| this.routesFeatureStore.layer.map.ol.addInteraction(interaction) | ||
| ); | ||
| } else { | ||
| this.interactions.map((interaction) => | ||
| this.routesFeatureStore.layer.map.ol.removeInteraction(interaction) | ||
| ); | ||
| } |
There was a problem hiding this comment.
Simplification possible:
Suggested change
| if (toggle) { | |
| this.interactions.map((interaction) => | |
| this.routesFeatureStore.layer.map.ol.addInteraction(interaction) | |
| ); | |
| } else { | |
| this.interactions.map((interaction) => | |
| this.routesFeatureStore.layer.map.ol.removeInteraction(interaction) | |
| ); | |
| } | |
| const ol = this.routesFeatureStore.layer.map.ol; | |
| this.interactions.map((interaction) => | |
| toggle ? ol.addInteraction(interaction) : ol.removeInteraction(interaction); | |
| ); |
alecarn
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
There is no method to disable map's interaction from the user.
What is the new behavior?
Add a toogle to allow the user to enable/disable the map interaction.
This is useful if the user wants to query the map, not add a intermediate point.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: