fix(menu-button): fix v16.0.0 regression form menu button color configuration #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
requested changes
Sep 21, 2023
| @@ -1,26 +1,5 @@ | |||
| @use '../../../../../common/src/style/partial/common-utils'; | |||
There was a problem hiding this comment.
C'est dommage de croiser nos logique de packages comme ça, en espérant que #1346 fix ce problème.
Pourquoi ce bouton ne se retrouve pas dans le package "Common"?
alecarn
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
In version 16.0.0 rc.0 the menu button with reversed color, the reversed color is not applied.
What is the new behavior?
Applied the reversed color.
I think that the menuButtonReverseColor configuration should be rename as menuButtonUseThemeColor or something like that.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: