perf(wfs): cancel outgoing wfs xhr on pan/zoom #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
requested changes
Sep 29, 2023
| (this.previousOgcFilters && this.previousOgcFilters !== ogcFilters) | ||
| ) { | ||
| vectorSource.removeLoadedExtent(this.previousLoadExtent); | ||
| this.xhrAccumulator.map((xhr) => xhr.abort()); |
There was a problem hiding this comment.
We could use the forEach instead of the map, it's more efficient for a simple iteration and even better would be the "for of". I think it's important in the scenario that this could be a very in-demand method.
alecarn
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Previous wfs call are not cancelled on pan/zoom, and still, they are not loaded into the source.
What is the new behavior?
cancel outgoing wfs xhr on pan/zoom
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: