Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geo, common): Integrate ngx color #1422

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Conversation

aziz-access
Copy link
Contributor

What is the current behavior? (You can also link to an open issue here)

this behavior integrate ngx-color to solve the issues of color alpha

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@aziz-access aziz-access self-assigned this Sep 28, 2023
@aziz-access aziz-access added bug Incorrect or unexpected behaviors // Anomalies de fonctionnement in progress In progress // Développement en cours labels Sep 28, 2023
@alecarn alecarn requested a review from pelord September 28, 2023 20:07
@alecarn
Copy link
Collaborator

alecarn commented Sep 28, 2023

@pelord ready for your review

@alecarn alecarn removed the in progress In progress // Développement en cours label Sep 29, 2023
Copy link
Member

@pelord pelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove console.log pls.

@alecarn alecarn merged commit e920a41 into release/16.0.0 Oct 2, 2023
1 check passed
@alecarn alecarn deleted the integrate-ngx-color branch October 2, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or unexpected behaviors // Anomalies de fonctionnement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants