Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(common): interactive-tour add the auto placement #1457

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix(common): interactive-tour add the auto placement #1457

merged 2 commits into from
Oct 25, 2023

Conversation

alecarn
Copy link
Collaborator

@alecarn alecarn commented Oct 20, 2023

@alecarn alecarn requested a review from pelord October 20, 2023 13:35
@alecarn alecarn self-assigned this Oct 20, 2023
@alecarn alecarn mentioned this pull request Oct 20, 2023
Merged
pelord
pelord approved these changes Oct 25, 2023
View reviewed changes
packages/common/src/lib/interactive-tour/interactive-tour.service.ts Outdated
for (const step of stepConfig.steps) {
for (const step of tourConfig.steps) {
const position = step.position ?? tourConfig.position;
console.log(position);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups

@pelord pelord merged commit 0087ace into release/16.0.0 Oct 25, 2023
1 check passed
@pelord pelord deleted the 1054-linteractive-tour-en-mode-auto-problème-daffichage-sur-mobile-lib branch October 25, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelord pelord pelord approved these changes

Assignees

@alecarn alecarn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alecarn @pelord