fix(common): fix sidenav button scrollUp and scrolldown #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
the
bug
alecarn
requested changes
Nov 13, 2023
…into 1083-probleme-barre-de-defilement-des-outils-a-gauche
https://github.com/infra-geo-ouverte/igo2-lib into 1083-probleme-barre-de-defilement-des-outils-a-gauche
alecarn
requested changes
Nov 14, 2023
| @@ -41,7 +41,7 @@ $igo-actionbar-item-icon-padding: 8px; | |||
| top: 0; | |||
| background-color: white; | |||
| z-index: 3; | |||
|
|
|||
| padding: 4px; | |||
There was a problem hiding this comment.
Qu'arrive t'il si on décide de donner plus de largeur au menu de gauche? Est-ce qu'on pourrait utiliser une méthode générique pour centrer le bouton, par exemple donner à son parent un display flex et avec une justification du contenu centré.
…into 1083-probleme-barre-de-defilement-des-outils-a-gauche
alecarn
approved these changes
Nov 14, 2023
alecarn
deleted the
1083-probleme-barre-de-defilement-des-outils-a-gauche
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this behavior related to #1803
What is the new behavior?
solve issues with sidenav controle buttons scrollUp and scrolldown
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: