Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core, integration): fix advanced map tool view and core media det… #1505

Merged
merged 7 commits into from
Nov 28, 2023
Merged

fix(core, integration): fix advanced map tool view and core media det… #1505

merged 7 commits into from
Nov 28, 2023

Conversation

aziz-access
Copy link
Contributor

@aziz-access aziz-access commented Nov 17, 2023 •
edited by alecarn

What is the current behavior? (You can also link to an open issue here)

this behavior related to #1500

Linked PR: https://github.com/infra-geo-ouverte/igo2/pull/1091/files

@aziz-access aziz-access self-assigned this Nov 17, 2023
@aziz-access aziz-access added bug Incorrect or unexpected behaviors // Anomalies de fonctionnement in progress In progress // Développement en cours labels Nov 17, 2023
@aziz-access aziz-access linked an issue Nov 17, 2023 that may be closed by this pull request
boutons +- disparaissent et affichage mode mobile Outils avancés #1500
Closed
@alecarn alecarn self-requested a review November 21, 2023 14:20
@alecarn alecarn marked this pull request as draft November 21, 2023 15:06
@alecarn alecarn marked this pull request as ready for review November 24, 2023 13:58
alecarn
alecarn approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@alecarn alecarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aziz-access pourrais-tu refaire un QA. J'ai apporté quelques modifications a cette PR

...ation/src/lib/map/advanced-map-tool/advanced-coordinates/advanced-coordinates.component.html Outdated Show resolved Hide resolved
@alecarn alecarn mentioned this pull request Nov 27, 2023
Merged
@alecarn alecarn requested a review from pelord November 27, 2023 15:47
@aziz-access
Copy link
Contributor Author

@aziz-access pourrais-tu refaire un QA. J'ai apporté quelques modifications a cette PR

@alecarn QA testée et approuvée

pelord
pelord requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@pelord pelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo must be modified to represent theses changes.

image

Check every pages based on map,

@alecarn alecarn requested a review from pelord November 28, 2023 20:28
@pelord pelord merged commit a4c9f2c into next Nov 28, 2023
4 checks passed
@pelord pelord deleted the minor-style-refactoring-advanced-tool-and-zoom-buttons branch November 28, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelord pelord pelord approved these changes

@alecarn alecarn alecarn approved these changes

Assignees

@aziz-access aziz-access

Labels
bug Incorrect or unexpected behaviors // Anomalies de fonctionnement in progress In progress // Développement en cours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boutons +- disparaissent et affichage mode mobile Outils avancés
3 participants
@aziz-access @pelord @alecarn