Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: refact the lib publishing and the github page #1526

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

alecarn
Copy link
Collaborator

@alecarn alecarn commented Dec 4, 2023

The publishing was broken with the new Workspace structure... we need to publish from the root.
This is a refactor of the publishing and in the same time we simplify the root Package.json scripts with the remove of all Github pages variant Windows/Linux

package.json Show resolved Hide resolved
"preversion": "npm run test && npm run e2e",
"version": "npm run release.lib && npm run release.ghpages",
"postversion": "npm run changelog && git add -u && git push && git push --tags",
"release.lib": "ts-node scripts/src/release/release.ts",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo lib au pluriel?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pas nécessaire.

package.json Outdated Show resolved Hide resolved
scripts/src/release/github-page.ts Outdated Show resolved Hide resolved
@alecarn alecarn self-assigned this Dec 6, 2023
Copy link
Member

@pelord pelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que tu fais la même logique dans l'assemblage?

package.json Show resolved Hide resolved
"preversion": "npm run test && npm run e2e",
"version": "npm run release.lib && npm run release.ghpages",
"postversion": "npm run changelog && git add -u && git push && git push --tags",
"release.lib": "ts-node scripts/src/release/release.ts",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pas nécessaire.

package.json Outdated Show resolved Hide resolved
@alecarn alecarn changed the base branch from next to release/16.1.0 December 11, 2023 13:43
@alecarn alecarn merged commit 9573191 into release/16.1.0 Dec 11, 2023
3 checks passed
@alecarn alecarn deleted the fix-lib-deployment branch December 11, 2023 13:43
@alecarn
Copy link
Collaborator Author

alecarn commented Dec 11, 2023

@pelord J'ai créer une issue du côté de IGO2, le temps me manque!
infra-geo-ouverte/igo2#1107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants