-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(demo): Repaired broken layers, added typing, removed unused imports/variables #1549
Conversation
sourceOptions: { | ||
type: 'osm' | ||
} | ||
}) | ||
.subscribe((layer) => this.map.addLayer(layer)); | ||
} as LayerOptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On essaie autant que possible d'utiliser l'opérateur satisfies
au lieu du as
. Parce que ce dernier force le type et empêche Typescript de faire sa validation du type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voir les commentaires.
projects/demo/src/app/geo/import-export/import-export.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
faire un pr pour la demo de stylesavailable svp.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Some sections of the "geo" demo had broken tools or layers.
What is the new behavior?
Layers have been repaired, typing has been added for claiity, tools (ie. print) have been repaired, imports/varaibles have been cleaned.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: