Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(geo): fix search bar floating label #1562

Merged
merged 6 commits into from
Jan 17, 2024

Conversation

aziz-access
Copy link
Contributor

What is the current behavior? (You can also link to an open issue here)

if we add the label in search bar <igo-search-bar [label]="'test'"></igo-search-bar>: the label is hidden.

What is the new behavior?

this behavior solve the label issue of igo-search-bar.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@aziz-access aziz-access changed the base branch from master to next January 8, 2024 20:28
@aziz-access aziz-access self-assigned this Jan 8, 2024
@aziz-access aziz-access added the bug Incorrect or unexpected behaviors // Anomalies de fonctionnement label Jan 8, 2024
@aziz-access aziz-access linked an issue Jan 8, 2024 that may be closed by this pull request
@alecarn alecarn requested a review from pelord January 11, 2024 13:42
@pelord pelord merged commit 3956b75 into next Jan 17, 2024
4 checks passed
@pelord pelord deleted the 1541-search-bar-style-regression branch January 17, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or unexpected behaviors // Anomalies de fonctionnement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search-bar style regression
3 participants