feat(geo): add modularity for search and direction #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecarn
commented
Apr 16, 2024
| @@ -65,7 +67,8 @@ import { | |||
| DirectionsInputsComponent, | |||
| DirectionsResultsComponent, | |||
| TranslateModule | |||
| ] | |||
| ], | |||
| providers: [provideSearch([withCoordinatesReverseSource()])] | |||
There was a problem hiding this comment.
@pelord Pourrais-tu vérifier que c'est correct comme source de recherche.
alecarn
force-pushed
the
common--1405-analysis-of-the-size-of-our-packages-and-strategies-to-optimize-them
branch
from
2e99110
to
c955927
Compare
alecarn
force-pushed
the
refact-search-and-direction-to-be-modular
branch
from
d941b82
to
08fff57
Compare
BREAKING CHANGE: - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root. - Analytics capability is provided with the SearchService directly. - DirectionModule, provideDirectionsSourceService is removed, use the provideDirection.
alecarn
force-pushed
the
refact-search-and-direction-to-be-modular
branch
from
08fff57
to
a726631
Compare
Base automatically changed from
common--1405-analysis-of-the-size-of-our-packages-and-strategies-to-optimize-them
to
next
May 15, 2024 20:15
aziz-access
added a commit
that referenced
this pull request
May 23, 2024
author aziz <aziz@access-international.dev> 1711040184 +0100 committer aziz <aziz@access-international.dev> 1716486949 +0200 fix(geo): Print set the same horizontal margin for the map code review code improvment change variable name fix(geo): print - map position, comment and projection position and georeference code review change variable names add comments and change variable name merge and update solve comments solve package lock issue Revert "fix(geo): Print set the same horizontal margin for the map" This reverts commit e63c672. fix(common): export EntityOperation like it used to (#1658) fix(integration): check if workspace search source is defined (#1609) fix(geo): inporting vector (igo2 issues #1146) * refactor(geo): move detect epsg to projection utils * refactor(geo): refactor based on review * wip * wip * wip feat(auth): configure auth with provider BREAKING CHANGE: AuthModule is deprecated and use the provideAuthentification for the configuration feat(auth): remove auth.module for circular dependency BREAKING CHANGE: Replace by provideAuth and call the component directly v17.0.0-next.5 feat(geo): update Openlayers to v9 (#1642) feat: replace our icon library @mdi/angular-material with the Google Font - Material Symbol (#1664) * feat(common): icon add provider to register icon class for symbol BREAKING CHANGE - Breaking change: The CoreModule doesn't instantiate the icon anymore. We need to explicitly call the provideIcon() in our main file update packages build: v17.0.0-next6 fix(icon): revert some icon change fix(core): remove duplicated load of config BREAKING CHANGE - The behavior is change call the forRoot to call the provideConfig and provideTranslation. - provideConfigLoader and provideConfigOptions is remove call provideConfig directly fix(geo): register svg icon for layer-list fix(utils): remove moment.js and delete datetime.utils BREAKING CHANGE- This file was added in the v16 but was not documented. Maybe we could mute this one fix(search-bar): trigger search on click fix(auth): use IgoAuthModule instead of TranslateModule build(geo): make test work build(auth): include all test and mock translation fix(utils): Vitejs raise an error without the default import fix(geo): ensure ogc filter accept today and now (#1622) feat(directions): added possibility to toggle between two routing sources (#1644) feat(integration): catalog keep selection when changing tools (#1654) fix(context): add workspace option with layers when we export context (#1660) fix(integration): update coordinate if projection system change (#1661) fix(geo): import and export shp file (#1665) * fix(geo): transfer isValidJSON function to utils pakage Common - convert in sub-packages (#1668) * feat(core): add message provider * feat(common): refact in submodule BREAKING CHANGE feat(geo): add modularity for search and direction (#1669) * feat(geo): add modularity for search and direction BREAKING CHANGE: - SearchState and SearchService no more provided in root. They depend on the SearchSource who are no more provided in the root. - Analytics capability is provided with the SearchService directly. - DirectionModule, provideDirectionsSourceService is removed, use the provideDirection. 17.0.0-next.7 deploy v17.0.0-next.7 fix(demo): directions add required search sources fix(demo): add doc for icons refactor(integration): change icon for proximity tool (#1679) fix: ol version to 9.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avec l'ajout de "lazy-loading", certain module était non fonctionnel et nécessitait des changements sur la manière dont il était assemblé.
Pour tester, s'assurer d'utliser les changements de la PR de igo2 infra-geo-ouverte/igo2#1156