Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui(map-details-tool): empty map message #560

Merged
merged 8 commits into from
Jan 30, 2020
Merged

ui(map-details-tool): empty map message #560

merged 8 commits into from
Jan 30, 2020

Conversation

PhilippeLafreniere18
Copy link
Contributor

Message for map-details-tool when no layers is currently added to the map

mbarbeau
mbarbeau requested changes Jan 24, 2020
View reviewed changes
Copy link
Member

@mbarbeau mbarbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. check that the tool is available before adding the link to it
  2. activateTool must be in integration module instead of assembly

@mbarbeau mbarbeau merged commit 53cc7ec into master Jan 30, 2020
@mbarbeau mbarbeau deleted the mapToolEmpty branch January 30, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarbeau mbarbeau mbarbeau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PhilippeLafreniere18 @mbarbeau