Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to disable config file watcher #150

Closed
PrasadG193 opened this issue Aug 9, 2019 · 1 comment · Fixed by #152
Closed

Ability to disable config file watcher #150

PrasadG193 opened this issue Aug 9, 2019 · 1 comment · Fixed by #152
Assignees
@codenio
Labels
enhancement New feature or request
Milestone
v0.9.0

Comments

@PrasadG193
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
One should be able to disable auto restart on config file change through the BotKube configuration flags.

Describe the solution you'd like
We can add a flag like - settings.configWatcher=true/false to enable/disable this feature.
@PrasadG193 PrasadG193 added the enhancement New feature or request label Aug 9, 2019
@PrasadG193 PrasadG193 mentioned this issue Aug 9, 2019
Closed
@sanketsudake sanketsudake added this to the v0.9.0 milestone Aug 9, 2019
@codenio
Copy link
Contributor

codenio commented Aug 9, 2019

Looks cool to overcome bugs 👍 and get us unblocked for 0.9.0

@codenio codenio mentioned this issue Aug 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codenio codenio

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Add flag to control Config Watcher codenio/botkube
3 participants
@sanketsudake @PrasadG193 @codenio