Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/delete double whitespace #118

Merged

Conversation

Projects
None yet
3 participants
@nnao45
Copy link
Contributor

commented Jul 5, 2019

ISSUE TYPE
  • Feature Pull Request
SUMMARY

botkube receive command, include not one whitespace, butwork.
for example, 「@botkube get node」("@botkube" " " "get" " " " " "node" )

I think, botkube sould convert one or more spaces into one space

@PrasadG193

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Hi @nnao45 , thanks for the PR. Could you please rebase your branch with develop?

@ssudake21 ssudake21 requested a review from PrasadG193 Jul 8, 2019

@nnao45 nnao45 force-pushed the nnao45:patch/delete-double-whitespace branch from 6dc2f63 to d9bfce4 Jul 8, 2019

@nnao45

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@PrasadG193
rebase my branch with develop.

Show resolved Hide resolved pkg/utils/utils.go Outdated

@PrasadG193 PrasadG193 merged commit 2ebc040 into infracloudio:develop Jul 8, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.