Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(integration): Move integration tests to tests/ #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bhargav-InfraCloud
Copy link

@Bhargav-InfraCloud Bhargav-InfraCloud commented Mar 5, 2024

Description

Move integration tests to tests/.

Fixes 297

How Has This Been Tested?

Run the following commands and check if running successful:

# This should print all the tests related commands under a separate heading
make help

# Individual types of tests
make test-unit
make test-coverage
make test-integration

# These should run all the above tests
make test
make test-docker

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR requires documentation updates?
  • I've updated documentation as required by this PR.
  • I have ran go fmt
  • I have updated the helm chart as required by this PR.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested it for all user roles.
  • I have added all the required unit test cases.
  • I have verified the E2E test cases with new code changes.
  • I have added all the required E2E test cases.

Does this PR introduce a breaking change?


@Bhargav-InfraCloud Bhargav-InfraCloud self-assigned this Mar 5, 2024
@Bhargav-InfraCloud
Copy link
Author

Separated tests and updated the Makefile targets accordingly. Working on adding coverage.

@Bhargav-InfraCloud Bhargav-InfraCloud force-pushed the br_reorganize_tests branch 2 times, most recently from ef37b7c to 6df2201 Compare March 6, 2024 07:17
@Bhargav-InfraCloud Bhargav-InfraCloud marked this pull request as ready for review March 6, 2024 07:19
Copy link

@ApsTomar ApsTomar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bhargav-InfraCloud Bhargav-InfraCloud force-pushed the br_reorganize_tests branch 2 times, most recently from 4f02c6e to 427a2c6 Compare April 6, 2024 22:47
Move tests-related targets in Makefile to a separate section `Test`.

Signed-off-by: Bhargav Ravuri <bhargav.ravuri@infracloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants