Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to ignore failures in CI/CD #1478

Closed
alikhajeh1 opened this issue Mar 21, 2022 · 3 comments
Closed

Option to ignore failures in CI/CD #1478

alikhajeh1 opened this issue Mar 21, 2022 · 3 comments
Labels
enhancement New feature or request new integration New integration with external product/tool (CI/CD, code editor, etc)

Comments

@alikhajeh1
Copy link
Member

alikhajeh1 commented Mar 21, 2022

It seems useful to have a CI/CD option, e.g. INFRACOST_WARN_ON_FAILURE=true, to ignore failures so a warning is logged but PRs are not blocked when something fails. The failure can happen for whatever reason, e.g. a CLI panic or the AWS region used by our hosted service goes down. Spacelift have already added this option.

Note for community

Please 👍 if you'd like to upvote this or receive updates.

@alikhajeh1 alikhajeh1 added enhancement New feature or request new integration New integration with external product/tool (CI/CD, code editor, etc) labels Mar 21, 2022
@PatMyron
Copy link
Contributor

Can also generally workaround with || true

@alikhajeh1
Copy link
Member Author

@PatMyron good workaround! I think CodeCov did something similar with || echo "Error running X..." for their legacy bash-uploader.

@alikhajeh1
Copy link
Member Author

Going to close this issue as it's not been brought-up much and the workaround that @PatMyron seems simple and solid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new integration New integration with external product/tool (CI/CD, code editor, etc)
Projects
None yet
Development

No branches or pull requests

2 participants