Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for AWS API GatewayV2 HTTP & WebSocket API. #12

Merged
merged 6 commits into from
Nov 9, 2020
Merged

Added support for AWS API GatewayV2 HTTP & WebSocket API. #12

merged 6 commits into from
Nov 9, 2020

Conversation

robh007
Copy link
Contributor

@robh007 robh007 commented Nov 8, 2020

This compliments infracost pull request infracost/infracost#207. This provides the ability to estimate HTTP & WebSocket API requests & messages.

** Testing Output **

make testacc TESTARGS='-run=TestAwsApiGatewayV2Api'
TF_ACC=1 go test ./... -v -run=TestAwsApiGatewayV2Api -timeout 120m
?       github.com/infracost/terraform-provider-infracost       [no test files]
=== RUN   TestAwsApiGatewayV2Api
--- PASS: TestAwsApiGatewayV2Api (0.04s)
PASS
ok      github.com/infracost/terraform-provider-infracost/infracost     3.098s

alikhajeh1
alikhajeh1 requested changes Nov 8, 2020
View reviewed changes
Copy link
Member

@alikhajeh1 alikhajeh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Added my tiny suggestions, I'm happy to merge this PR without the validateFunc too as that can be done in a separate PR if we decide to do it...

docs/data-sources/aws_apigatewayv2_api.md Outdated Show resolved Hide resolved
docs/data-sources/aws_apigatewayv2_api.md Outdated Show resolved Hide resolved
infracost/data_source_aws_apigatewayv2_api.go
Read: dataSourceRead,
Schema: map[string]*schema.Schema{
"resources": resourcesSchema(),
"average_message_size": usageSchema(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should change usageSchema to accept an optional validateFunc? see https://www.terraform.io/docs/extend/schemas/schema-behaviors.html#validatefunc

@aliscott any thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aliscott, I created #13 so we can don't block this PR from being merged.

@alikhajeh1 alikhajeh1 mentioned this pull request Nov 9, 2020
Closed
@alikhajeh1 alikhajeh1 merged commit bfedbea into infracost:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliscott aliscott aliscott left review comments

@alikhajeh1 alikhajeh1 alikhajeh1 requested changes

Assignees

@robh007 robh007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robh007 @aliscott @alikhajeh1