Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Infracost usage file #6

Closed
hugorut opened this issue Jun 29, 2022 · 11 comments · Fixed by #154
Closed

Support Infracost usage file #6

hugorut opened this issue Jun 29, 2022 · 11 comments · Fixed by #154
Labels
enhancement New feature or request
Milestone

Comments

@hugorut
Copy link
Collaborator

hugorut commented Jun 29, 2022

Resources that solely use usage costs will have a 0.00 cost shown. We should alter the extension to allow users to supply a usage file, or parse it from a known location/name.

It's better that the logic lay within the Infracost CLI. As the VSCode native solution did not detect initialization.


Note for community
Please 👍 if you'd like to upvote this or receive updates.
Add a comment if you'd like to contribute.

@hugorut hugorut added the enhancement New feature or request label Jun 29, 2022
@marconneves
Copy link

I think this is perfect, at first just identifying a file as an 'infracost-usage.yml' along with the terraform files, but in the future it would be perfect to be able to select the extension

@matthieupetite
Copy link

Hello, I've just made a small change in the extension.ts file to add the support of infracost usage file by updating the breakdown command if I detect the presence of a infracost-usage.yml file in the project. I also add that file in the isValidTerraform file to re execute the infracost calculation if the infracost usage data is updated. I can do a PR if needed but for that I need to clean my code. Let me know if it's interesting for you and I will proceed

@hugorut
Copy link
Collaborator Author

hugorut commented Aug 16, 2022

Hey @matthieupetite, sure thing, open a PR and we can have a look ❤️

@matthieupetite
Copy link

Ok, I do that after cleaning my code ... probably tonight or tomorrow ;)

@alikhajeh1
Copy link
Member

@matthieupetite just wondering if there were any updates on this? Another user ran into an issue, which I think would be addressed by your proposed solution (detect infracost-usage.yml).

@hugorut
Copy link
Collaborator Author

hugorut commented Nov 14, 2022

@alikhajeh1, @matthieupetite delivered a solution native to the VSCode extension, but it was decided that it was better that the logic lay within the CLI. As the VSCode native solution did not detect initialization.

@alikhajeh1
Copy link
Member

Thanks for clarifying! I updated the issue desc.

@hugorut hugorut added this to the 0.3.0 milestone Dec 5, 2022
@hugorut hugorut added this to To do in Kanban board via automation Dec 5, 2022
@matthieupetite
Copy link

Hello, I come back on this issue to see if there is a planned date for this. I am still working with my fork but it's too tricky and unstable :(

@hugorut
Copy link
Collaborator Author

hugorut commented Jan 11, 2023

@matthieupetite I don't have an ETA on this unfortunately. I'll try and work on something this weekend, with aim to get a relase out late next week.

hugorut added a commit that referenced this issue Jun 5, 2023
closes #6 and #7

* Adds initial support for top workspace level config file
* Adds support for workspace level usage file and project level usage file
hugorut added a commit that referenced this issue Jun 6, 2023
closes #6 and #7

* Adds initial support for top workspace level config file
* Adds support for workspace level usage file and project level usage file
hugorut added a commit that referenced this issue Jun 7, 2023
closes #6 and #7

* Adds initial support for top workspace level config file
* Adds support for workspace level usage file and project level usage file
hugorut added a commit that referenced this issue Jun 7, 2023
closes #6 and #7

* Adds initial support for top workspace level config file
* Adds support for workspace level usage file and project level usage file
Kanban board automation moved this from To do to Done Jun 7, 2023
@hugorut hugorut reopened this Jun 7, 2023
Kanban board automation moved this from Done to In progress Jun 7, 2023
@hugorut
Copy link
Collaborator Author

hugorut commented Jun 7, 2023

Hi all, we've added usage file support as part of the 0.2.11 release. The recommended way to let the extension know about usage, is by referencing it in a Infracost config file. Please give the latest release a whirl and let us know any bugs you find. 🙏 .

@hugorut hugorut closed this as completed Jun 7, 2023
Kanban board automation moved this from In progress to Done Jun 7, 2023
@matthieupetite
Copy link

Thanks a lot for that release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

4 participants