Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose plaintext server for ingress #122

Merged
merged 2 commits into from
Jul 20, 2021
Merged

Expose plaintext server for ingress #122

merged 2 commits into from
Jul 20, 2021

Conversation

jmorganca
Copy link
Contributor

Several users have mentioned the need to use Infra behind Kubernetes Ingress configurations for TLS termination. To support this, we need (especially for GRPC traffic) to expose an alternative, plaintext port for users to connect to behind their own TLS-terminated load balancers or ingress controllers.

@jmorganca jmorganca requested a review from BruceMacD July 20, 2021 01:51
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I see we default the client to 443, so I don't mind enabling this by default.

@jmorganca jmorganca merged commit 9f892d2 into main Jul 20, 2021
@jmorganca jmorganca deleted the plaintext branch July 21, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants