Auto detect cluster name on eks, aks, gke #131
Conversation
| return "", err | ||
| } | ||
|
|
||
| req.Header.Add("Metadata-Flavor", "Google") |
There was a problem hiding this comment.
I prefer my metadata to be chocolate flavor 🍨
There was a problem hiding this comment.
Was stuck on this for an hour. Ends up no flavor = no answer from the metadata api
🙃
|
|
||
| func (k *Kubernetes) Name() (string, error) { | ||
| name, err := eksClusterName() | ||
| if err == nil { |
There was a problem hiding this comment.
I think we should log the response errors at the debug level rather than completely ignoring them, just in case we are ever trying to figure out why a name isn't getting assigned.
There was a problem hiding this comment.
Great catch. Will get some logging in here before returning an error if we can't automatically determine the cluster name.
There was a problem hiding this comment.
For now will log a generic error, but I've created an issue to use zap logging for the engine as well: #134
|
@BruceMacD yes, having a CA is a must-have for in any kubernetes cluster to my knowledge. However, I do wonder about the case where a user creates two clusters with the same private CA. I don't think this is possible with GKE/EKS/AKS (or almost any other kubernetes setup) but that is something to watch out for. |
cluster-<short hash of cluster CA>(e.g.cluster-79b0c378), which should be unique per cluster (is there a better alternative here?)infra engine --nameto force a name. This is probably what will be done when spinning up clusters via infrastructure-as-code.Before merging (or shortly after) it may be important to support
docker-desktopand perhapsminikubefor users who are trying out Infra locally.Fixes #42