Separate helm charts for registry and engine #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorganca
force-pushed
the
separate-helm-charts
branch
from
5a19ba9
to
778fcb7
Compare
BruceMacD
approved these changes
Jul 30, 2021
config.yaml
Outdated
| @@ -0,0 +1,20 @@ | |||
| sources: | |||
There was a problem hiding this comment.
This config is out of date, should have the names like this:
sources:
- type: okta
oktaDomain: acme.okta.com
oktaClientId: 0oapn0qwiQPiMIyR35d6
oktaClientSecret: jfpn0qwiQPiMIfs408fjs048fjpn0qwiQPiMajsdf08j10j2
oktaApiToken: 001XJv9xhv899sdfns938haos3h8oahsdaohd2o8hdao82hd
users:
- name: admin@example.com
roles:
- name: admin
kind: cluster-role
clusters:
- cluster-AAA
- cluster-BBB
- name: user@example.com
roles:
- name: writer
kind: cluster-role
clusters:
- cluster-AAA
- name: reader
kind: cluster-role
clusters:
- cluster-BBB
There was a problem hiding this comment.
Accidentally added this (outdated) test config.yaml file - will remove
docs/configuration.md
Outdated
| * [`user`](#user) | ||
| * [`destination`](#destination) | ||
| * [`role`](#role) | ||
| * [`users`](#roles) |
There was a problem hiding this comment.
Should this be [`users`](#users)?
jmorganca
force-pushed
the
separate-helm-charts
branch
from
778fcb7
to
8a1397e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
I've also added the config file as a nice
--set-file=./infra.yamlparameter value for the helm chart, which will make loading a config file into a Kubernetes-hosted registry very easy/convenient. cc @BruceMacD