Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: cli: select grants by user, supports inherited #2551

Merged
merged 1 commit into from
Aug 15, 2022
Merged

feature: cli: select grants by user, supports inherited #2551

merged 1 commit into from
Aug 15, 2022

Conversation

ssoroka
Copy link
Contributor

@ssoroka ssoroka commented Jul 11, 2022

Summary

see slack

Checklist

  • Wrote appropriate unit tests
  • Considered security implications of the change
  • Updated associated docs where necessary
  • Updated associated configuration where necessary
  • Change is backwards compatible if it needs to be (user can upgrade without manual steps?)
  • Nothing sensitive logged
  • Considered data migrations for smooth upgrades

Related Issues

Resolves #

@ssoroka ssoroka changed the title draft: feature: cli: select grants by user, supports inherited Draft: feature: cli: select grants by user, supports inherited Jul 11, 2022
@ssoroka ssoroka marked this pull request as draft July 11, 2022 15:06
@ssoroka ssoroka changed the title Draft: feature: cli: select grants by user, supports inherited feature: cli: select grants by user, supports inherited Jul 11, 2022
@ssoroka
Copy link
Contributor Author

ssoroka commented Jul 11, 2022

seems the CLI tests trying to mock out every api call is fairly brittle.

dnephin
dnephin reviewed Jul 15, 2022
View reviewed changes
Copy link
Contributor

@dnephin dnephin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

internal/cmd/grants.go Show resolved Hide resolved
@ssoroka ssoroka marked this pull request as ready for review August 8, 2022 16:29
@vercel vercel bot temporarily deployed to Preview August 8, 2022 16:34 Inactive
BruceMacD
BruceMacD approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this PR slipped through the cracks somehow

@ssoroka ssoroka merged commit f41fe28 into main Aug 15, 2022
@ssoroka ssoroka deleted the cmd-inherited branch August 15, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnephin dnephin dnephin left review comments

@BruceMacD BruceMacD BruceMacD approved these changes

@kimskimchi kimskimchi Awaiting requested review from kimskimchi

@jmorganca jmorganca Awaiting requested review from jmorganca

@pdevine pdevine Awaiting requested review from pdevine

@technovangelist technovangelist Awaiting requested review from technovangelist

@mchiang0610 mchiang0610 Awaiting requested review from mchiang0610

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ssoroka @dnephin @BruceMacD