feat: Icons revisit #2887
Merged
feat: Icons revisit #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorganca
reviewed
Aug 9, 2022
ui/pages/groups/index.js
Outdated
| <img alt='group icon' src='/groups.svg' className='h-3 w-3' /> | ||
| <div className='flex h-7 w-7 select-none items-center justify-center rounded-md border border-gray-800'> | ||
| <img | ||
| alt='group icon' |
There was a problem hiding this comment.
Can we use heroicons here?
Also we should use text-gray-500 or similar as the stroke color since the full white sticks out a bit too much
There was a problem hiding this comment.
not sure if this is what you are expecting but I decided to use text-gray-400 because it looks too dark for text-gray-500
jmorganca
reviewed
Aug 10, 2022
ui/pages/providers/index.js
Outdated
| @@ -101,6 +101,8 @@ export default function Providers() { | |||
| data: providers || [], | |||
| }) | |||
|
|
|||
| console.log(providers) | |||
jmorganca
approved these changes
Aug 10, 2022
added 2 commits
August 10, 2022 16:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
馃摲
Related Issues
Resolves #2877