-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve: refactor release workflow #2889
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxyng
requested review from
technovangelist,
dnephin,
jmorganca,
pdevine and
mchiang0610
as code owners
August 9, 2022 18:52
mxyng
commented
Aug 9, 2022
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 9, 2022 19:11
0292954
to
00e1750
Compare
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 9, 2022 19:21
00e1750
to
c133aaa
Compare
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 9, 2022 19:23
c133aaa
to
e7ada09
Compare
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 9, 2022 19:57
e7ada09
to
131b82c
Compare
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 9, 2022 19:58
131b82c
to
3d5e9f0
Compare
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 9, 2022 20:07
3d5e9f0
to
67617a1
Compare
mxyng
force-pushed
the
workflows-refactor-4
branch
from
August 10, 2022 01:36
53cca3e
to
c9294e6
Compare
mxyng
force-pushed
the
workflows-refactor-5
branch
2 times, most recently
from
August 10, 2022 19:08
b4feadb
to
341f06b
Compare
BruceMacD
reviewed
Aug 10, 2022
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 10, 2022 21:10
341f06b
to
b1bd74e
Compare
BruceMacD
approved these changes
Aug 11, 2022
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 11, 2022 16:33
b1bd74e
to
0b27f6b
Compare
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 11, 2022 16:34
0b27f6b
to
a5f9495
Compare
mxyng
force-pushed
the
workflows-refactor-5
branch
from
August 11, 2022 19:13
a5f9495
to
59f3210
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a release workflow which will create a Github release based on some inputs. Release notes are populated from
docs/changelog/*.md
. This action usesworkflow_dispatch
which can be triggered manually from the Github Actions UI. The deploy itself is pretty simple. It usesinfra
to setup a Kubernetes context and ArgoCD Image Updater to update the image backing the deployment. ArgoCD Image Updater can piggyback on the contextinfra
creates so no additional configurations is required.This also adds
workflow_run
which allows the configured workflows to trigger off other workflows. It's particularly useful for build and deploy which can trigger of CI tests and CD builds respectively.