maintain: google idp experience #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- align CLI and UI setup - give info about private key in ui
BruceMacD
requested review from
technovangelist,
dnephin,
jmorganca,
pdevine,
mchiang0610,
hoyyeva and
kimskimchi
as code owners
- formatting
ssoroka
approved these changes
Aug 22, 2022
| func parsePrivateKey(key string) (string, error) { | ||
| if json.Valid([]byte(key)) { | ||
| // parsePrivateKey checks if a service account key file was passed in and parses information from it | ||
| func parsePrivateKey(opts *providerAPIOptions) error { |
There was a problem hiding this comment.
I feel like moving providerAPIOptions into here makes it a little less reusable, but it seems ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improving the understandability of the Google provider setup experience. This change makes the CLI match the UI (both prompt for the service account key file), gives extra context in the UI, and improves flag naming for the domain admin.
Checklist
Related Issues
Resolves #2747