fix: hide connector grants #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-sneh
requested review from
ssoroka,
hoyyeva,
dnephin,
jmorganca,
pdevine and
BruceMacD
as code owners
BruceMacD
reviewed
Aug 11, 2022
internal/access/grant.go
Outdated
| @@ -68,6 +68,10 @@ func ListGrants(c *gin.Context, subject uid.PolymorphicID, resource string, priv | |||
| selectors = append(selectors, data.ByOptionalSubject(subject)) | |||
| } | |||
|
|
|||
| if !showSystem { | |||
| selectors = append(selectors, data.NotPrivilege(models.InfraConnectorRole)) | |||
There was a problem hiding this comment.
I think we will have to be more specific than this.
There could be a privilege called "connector" in other places outside of infra that its legit to create a grant for. We should hide system grants by something like privilege != connector && destination != infra together
ssoroka
reviewed
Aug 11, 2022
api/grant.go
Outdated
| @@ -38,6 +38,7 @@ type ListGrantsRequest struct { | |||
| Resource string `form:"resource" example:"production"` | |||
| Privilege string `form:"privilege" example:"view"` | |||
| ShowInherited bool `form:"showInherited" note:"if true, this field includes grants that the user inherits through groups"` | |||
| ShowSystem bool `form:"showSystem"` | |||
There was a problem hiding this comment.
add a note tag here so that the api docs know what this is.
ssoroka
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a natural continuation of this issue #2892, which was also causing a bug with the
infra grants listcommand.Checklist
Related Issues
Resolves #2909