improve: add component concurrency controls #2915
Conversation
mxyng
force-pushed
the
mxyng/component-concurrency-control
branch
from
f8eb43c
to
f2e362d
Compare
| @@ -25,7 +42,8 @@ jobs: | |||
| - name: Production | |||
| environment: ${{ matrix.environment.name }} | |||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.job }}-${{ matrix.environment.name }} | |||
| group: ${{ github.workflow }}-synchronize-${{ matrix.environment.name }}-${{ needs.prepare.outputs.component-name }} | |||
There was a problem hiding this comment.
github.job is only available in context of steps so hard code it here to synchronize
| @@ -25,7 +42,8 @@ jobs: | |||
| - name: Production | |||
| environment: ${{ matrix.environment.name }} | |||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.job }}-${{ matrix.environment.name }} | |||
| group: ${{ github.workflow }}-synchronize-${{ matrix.environment.name }}-${{ needs.prepare.outputs.component-name }} | |||
| cancel-in-progress: true | |||
There was a problem hiding this comment.
Workflow status is waiting when waiting for approvals and (presumably) during the wait timer so this is necessary. Otherwise new jobs will be pending until previous workflows have completed or expired.
This may be a problem if multiple workflows are created in quick succession and cancel each other while actually running but we'll figure it out when it gets to that point.
There was a problem hiding this comment.
Does this seem like it will fix the "stuck waiting for workflows" problem I saw in #2841?
There was a problem hiding this comment.
I'm not sure why #2841 had waiting workflows. It's possible it erroneously created the deploy workflow so I've add a branch filter but there's no strong evidence of that from the actions history
mxyng
force-pushed
the
mxyng/component-concurrency-control
branch
from
f2e362d
to
2473489
Compare
Summary
Minor change to the deploy workflow to add concurrency controls for individual components. A deploy for
coreshould not override/block deploys forui